Skip to content

Explore fewer constraints in getResolvedBaseConstraint #48613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2022
Merged

Explore fewer constraints in getResolvedBaseConstraint #48613

merged 1 commit into from
Apr 9, 2022

Conversation

ahejlsberg
Copy link
Member

Fixes #48552.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 8, 2022
@ahejlsberg
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 8, 2022 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at b7bbf2b. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 8, 2022 •
edited
Loading

Heya @ahejlsberg, I've started to run the diff-based community code test suite on this PR at b7bbf2b. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 8, 2022 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at b7bbf2b. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 8, 2022 •
edited
Loading

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at b7bbf2b. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..48613

Metric main 48613 Delta Best Worst
Angular - node (v14.15.1, x64)
Memory used 333,255k (± 0.01%) 333,268k (± 0.01%) +13k (+ 0.00%) 333,184k 333,306k
Parse Time 2.04s (± 0.54%) 2.02s (± 0.57%) -0.01s (- 0.64%) 2.01s 2.06s
Bind Time 0.87s (± 0.54%) 0.88s (± 0.68%) +0.00s (+ 0.57%) 0.86s 0.89s
Check Time 5.61s (± 0.47%) 5.63s (± 0.52%) +0.01s (+ 0.23%) 5.56s 5.69s
Emit Time 6.29s (± 0.39%) 6.30s (± 0.92%) +0.01s (+ 0.19%) 6.16s 6.44s
Total Time 14.81s (± 0.24%) 14.83s (± 0.46%) +0.02s (+ 0.11%) 14.68s 14.95s
Compiler-Unions - node (v14.15.1, x64)
Memory used 193,401k (± 0.63%) 194,307k (± 0.55%) +906k (+ 0.47%) 192,087k 195,410k
Parse Time 0.85s (± 0.40%) 0.85s (± 0.76%) -0.00s (- 0.12%) 0.84s 0.87s
Bind Time 0.56s (± 0.59%) 0.56s (± 0.72%) -0.00s (- 0.18%) 0.55s 0.57s
Check Time 7.44s (± 0.37%) 7.46s (± 0.28%) +0.02s (+ 0.30%) 7.42s 7.50s
Emit Time 2.51s (± 0.96%) 2.48s (± 0.55%) -0.02s (- 0.92%) 2.46s 2.52s
Total Time 11.36s (± 0.29%) 11.36s (± 0.23%) -0.00s (- 0.04%) 11.30s 11.42s
Monaco - node (v14.15.1, x64)
Memory used 325,441k (± 0.00%) 325,446k (± 0.01%) +6k (+ 0.00%) 325,410k 325,489k
Parse Time 1.57s (± 0.59%) 1.57s (± 0.65%) +0.00s (+ 0.06%) 1.55s 1.59s
Bind Time 0.77s (± 0.77%) 0.78s (± 1.15%) +0.00s (+ 0.13%) 0.76s 0.80s
Check Time 5.51s (± 0.50%) 5.50s (± 0.43%) -0.01s (- 0.11%) 5.47s 5.55s
Emit Time 3.32s (± 0.91%) 3.31s (± 0.78%) -0.01s (- 0.27%) 3.26s 3.39s
Total Time 11.17s (± 0.40%) 11.16s (± 0.39%) -0.01s (- 0.12%) 11.07s 11.29s
TFS - node (v14.15.1, x64)
Memory used 289,011k (± 0.01%) 289,010k (± 0.01%) -1k (- 0.00%) 288,946k 289,072k
Parse Time 1.36s (± 1.44%) 1.36s (± 1.25%) 0.00s ( 0.00%) 1.34s 1.42s
Bind Time 0.72s (± 0.77%) 0.72s (± 0.41%) -0.00s (- 0.00%) 0.72s 0.73s
Check Time 5.18s (± 0.38%) 5.18s (± 0.31%) +0.01s (+ 0.15%) 5.14s 5.21s
Emit Time 3.50s (± 2.03%) 3.49s (± 2.11%) -0.01s (- 0.17%) 3.38s 3.64s
Total Time 10.76s (± 0.65%) 10.76s (± 0.71%) +0.00s (+ 0.01%) 10.62s 10.93s
material-ui - node (v14.15.1, x64)
Memory used 447,698k (± 0.04%) 447,678k (± 0.06%) -19k (- 0.00%) 446,682k 447,823k
Parse Time 1.87s (± 0.57%) 1.87s (± 0.54%) +0.00s (+ 0.00%) 1.85s 1.90s
Bind Time 0.69s (± 0.99%) 0.70s (± 0.53%) +0.00s (+ 0.00%) 0.69s 0.70s
Check Time 13.01s (± 0.60%) 12.99s (± 0.62%) -0.01s (- 0.10%) 12.81s 13.16s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.58s (± 0.50%) 15.57s (± 0.53%) -0.01s (- 0.08%) 15.37s 15.74s
xstate - node (v14.15.1, x64)
Memory used 535,832k (± 0.00%) 535,836k (± 0.00%) +4k (+ 0.00%) 535,792k 535,879k
Parse Time 2.60s (± 0.45%) 2.59s (± 0.45%) -0.02s (- 0.58%) 2.57s 2.62s
Bind Time 1.15s (± 0.78%) 1.14s (± 0.46%) -0.01s (- 0.61%) 1.12s 1.15s
Check Time 1.50s (± 0.59%) 1.51s (± 0.44%) +0.01s (+ 0.67%) 1.49s 1.52s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.32s (± 0.22%) 5.31s (± 0.23%) -0.01s (- 0.23%) 5.28s 5.33s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory3 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 48613 10
Baseline main 10

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Collaborator

@ahejlsberg
Great news! no new errors were found between main..refs/pull/48613/merge

@ahejlsberg ahejlsberg merged commit a744862 into main Apr 9, 2022
@ahejlsberg ahejlsberg deleted the fix48552 branch April 9, 2022 14:06
Jack-Works pushed a commit to Jack-Works/TypeScript that referenced this pull request Apr 22, 2022
@ahejlsberg @Jack-Works
Explore fewer constraints in getResolvedBaseConstraint (microsoft#48613)
b20f7ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

Assignees

@ahejlsberg ahejlsberg

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.6.2 regression: Type instantiation is excessively deep and possibly infinite.
3 participants
@ahejlsberg @typescript-bot @RyanCavanaugh